Skip to content

[net] Deprecate T[S3]WebFile#21783

Merged
jblomer merged 3 commits intoroot-project:masterfrom
jblomer:deprecate-webfile
Apr 6, 2026
Merged

[net] Deprecate T[S3]WebFile#21783
jblomer merged 3 commits intoroot-project:masterfrom
jblomer:deprecate-webfile

Conversation

@jblomer
Copy link
Copy Markdown
Contributor

@jblomer jblomer commented Apr 2, 2026

HTTP remote I/O is also implemented in more modern ways in TDavixFile and TCurlFile.

@jblomer jblomer requested a review from pcanal April 2, 2026 19:45
@jblomer jblomer self-assigned this Apr 2, 2026
@jblomer jblomer changed the title [net] deprecate T[S3]WebFile [net] Deprecate T[S3]WebFile Apr 2, 2026
Comment thread roofit/roostats/test/stressRooStats.cxx Outdated
Copy link
Copy Markdown
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with additional simplification in stressRooStats).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Test Results

    22 files      22 suites   3d 5h 40m 32s ⏱️
 3 831 tests  3 830 ✅  1 💤 0 ❌
75 611 runs  75 593 ✅ 18 💤 0 ❌

Results for commit af717f9.

♻️ This comment has been updated with latest results.

@guitargeek
Copy link
Copy Markdown
Contributor

The direct web file usage in stressRooStats is not intended. In fact, the whole support for reference files on the web is not needed anymore, as we have the reference files added to the repository.

@jblomer jblomer force-pushed the deprecate-webfile branch from d1c36cb to af717f9 Compare April 4, 2026 21:23
@jblomer jblomer merged commit 6ecfefe into root-project:master Apr 6, 2026
29 of 30 checks passed
@jblomer jblomer deleted the deprecate-webfile branch April 6, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants